Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19023 )
Change subject: IMPALA-11566: Provide SQL parsing capabilities to other applications in the form of jar packages ...................................................................... Patch Set 2: (4 comments) Hi minghui, thanks for your contribution! I post some comments. http://gerrit.cloudera.org:8080/#/c/19023/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19023/2//COMMIT_MSG@1 PS2, Line 1: Parent: 19114c72 (IMPALA-11578: Exclude locality test for remote FS) can you add some UT? http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java File fe/src/main/java/org/apache/impala/analysis/StmtNode.java: http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/analysis/StmtNode.java@49 PS2, Line 49: @SuppressWarnings("unchecked") why use @SuppressWarnings here? http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java File fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java: http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java@82 PS2, Line 82: if (BackendConfig.INSTANCE != null && BackendConfig.INSTANCE.skipLookupSymbol()) { what is skipLookupSymbol() for? http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/util/StmtVisitor.java File fe/src/main/java/org/apache/impala/util/StmtVisitor.java: http://gerrit.cloudera.org:8080/#/c/19023/2/fe/src/main/java/org/apache/impala/util/StmtVisitor.java@26 PS2, Line 26: List<T> visit(StmtNode node); Why don't you use or extend org.apache.impala.util.Visitor? If this interface is necessary, can you add some description javadoc? -- To view, visit http://gerrit.cloudera.org:8080/19023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I246b088310f25b809d9e598c0ecc6613d9749ee3 Gerrit-Change-Number: 19023 Gerrit-PatchSet: 2 Gerrit-Owner: Minghui Zhu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Minghui Zhu <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 02:43:42 +0000 Gerrit-HasComments: Yes
