Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19001 )
Change subject: IMPALA-11562: Revert support for o3fs as default filesystem ...................................................................... Patch Set 8: (2 comments) LGTM! http://gerrit.cloudera.org:8080/#/c/19001/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test: http://gerrit.cloudera.org:8080/#/c/19001/8/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@77 PS8, Line 77: other > As far as I can tell the test cleans up after itself. Format deletes everyt Thanks for the clarification. http://gerrit.cloudera.org:8080/#/c/19001/8/tests/custom_cluster/test_startup_filesystem_checks.py File tests/custom_cluster/test_startup_filesystem_checks.py: http://gerrit.cloudera.org:8080/#/c/19001/8/tests/custom_cluster/test_startup_filesystem_checks.py@50 PS8, Line 50: "/" > Actually it's just checking that they're valid directories, checking '/' is Thanks for the explanation. -- To view, visit http://gerrit.cloudera.org:8080/19001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45e90d30b2e68876dec0db3c43ac15ee510b17bd Gerrit-Change-Number: 19001 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Sep 2022 09:18:33 +0000 Gerrit-HasComments: Yes
