Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19001 )
Change subject: IMPALA-11562: Revert support for o3fs as default filesystem ...................................................................... Patch Set 8: Code-Review+1 (1 comment) This makes sense to me. One thing that can happen is that developers add new tests without the appropriate prefix. One extension is that we could do is to have a way to run our normal tests with a special prefix and make precommit use it. We don't need to do that in this change, but it might be something to look at. http://gerrit.cloudera.org:8080/#/c/19001/8/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/19001/8/tests/authorization/test_ranger.py@309 PS8, Line 309: TestRanger._check_privileges(result, [ : [kw, id, "", "", "", "{0}{1}".format(NAMENODE, '/tmp'), "", "all", "false"]]) Just curious, why is /tmp special? We execute the grant with uri but then check /tmp here. -- To view, visit http://gerrit.cloudera.org:8080/19001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45e90d30b2e68876dec0db3c43ac15ee510b17bd Gerrit-Change-Number: 19001 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 28 Sep 2022 16:32:14 +0000 Gerrit-HasComments: Yes
