Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 )
Change subject: IMPALA-11604 Planner changes for CPU usage ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/19033/12/fe/src/main/java/org/apache/impala/analysis/SortInfo.java File fe/src/main/java/org/apache/impala/analysis/SortInfo.java: http://gerrit.cloudera.org:8080/#/c/19033/12/fe/src/main/java/org/apache/impala/analysis/SortInfo.java@323 PS12, Line 323: / Math.max(numInstances, 1); Still not comfortable with the division (by instances/cores) here. This is better done at the fragment level where the overall contention within the fragment an be assessed and applied uniformly to operators in the fragment. As minimum, there should be some non-linear adjustment in the divisor, i.e. numInstances^(0.8). Having the division here is also misleading since the function returns a per-thread estimate, no the overall processing cost. -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 11 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:50:52 +0000 Gerrit-HasComments: Yes
