Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 )
Change subject: IMPALA-11604 Planner changes for CPU usage ...................................................................... Patch Set 23: (5 comments) Address review comments and added the code to compute processing cost for different flavors of data sinks. http://gerrit.cloudera.org:8080/#/c/19033/16/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/19033/16/common/thrift/Frontend.thrift@740 PS16, Line 740: select > Not updated Sorry. Done this time :-). http://gerrit.cloudera.org:8080/#/c/19033/16/common/thrift/Frontend.thrift@750 PS16, Line 750: of data in by > Yes. The comment is updated. Removed 'per instance'. See class ProcessingCost. http://gerrit.cloudera.org:8080/#/c/19033/22/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/19033/22/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@299 PS22, Line 299: InstanceResourceProfile_ = > setProcessingCost() is not called for perInstanceResourceProfile_ Removed. http://gerrit.cloudera.org:8080/#/c/19033/22/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java File fe/src/main/java/org/apache/impala/planner/ResourceProfile.java: http://gerrit.cloudera.org:8080/#/c/19033/22/fe/src/main/java/org/apache/impala/planner/ResourceProfile.java@199 PS22, Line 199: processingCost_.multiply(factor)); : } : > getProcessingCost().multiply(factor) Great catch. Done. http://gerrit.cloudera.org:8080/#/c/19033/16/fe/src/main/java/org/apache/impala/util/AutoScaleUtil.java File fe/src/main/java/org/apache/impala/util/AutoScaleUtil.java: http://gerrit.cloudera.org:8080/#/c/19033/16/fe/src/main/java/org/apache/impala/util/AutoScaleUtil.java@39 PS16, Line 39: : public static ProcessingCost computeAndLogProcessingCost(String label, long cardinality, : float exprsCost, float avgRowSize, int numInstances) { : ProcessingCost processingCost = : computeProcessingCost(cardinality, exprsCost, avgRowSize, numInstances); > If computeProcessingCost() is called before calling getProcessingCostComput Refactor a bit. Done. -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 23 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Oct 2022 15:00:42 +0000 Gerrit-HasComments: Yes
