Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 )
Change subject: IMPALA-11604 Planner changes for CPU usage ...................................................................... Patch Set 25: (2 comments) Address review comments. Also split the computation of processing cost for exchange into two parts: 1. In exchange node: only for the receiving part; 2. In DateStreamSink: only for the sending part. This is because the sending part of the exchange node is embedded in the data stream sink of the bottom fragment; and the receiving part of the exchange is embedded in the top fragment. http://gerrit.cloudera.org:8080/#/c/19033/23/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java: http://gerrit.cloudera.org:8080/#/c/19033/23/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@42 PS23, Line 42: import org.apache.impala.util.BitUtil; : import org.apache.impala.util.ExprUtil; > nit: switch order of these two lines Done http://gerrit.cloudera.org:8080/#/c/19033/23/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/19033/23/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@29 PS23, Line 29: import org.apache.impala.util.AutoScaleUtil; : import org.apache.impala.util.ExprUtil; > nit: switch order of these two lines Done -- To view, visit http://gerrit.cloudera.org:8080/19033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If32dc770dfffcdd0be2b5555a789a7720952c68a Gerrit-Change-Number: 19033 Gerrit-PatchSet: 25 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Oct 2022 22:29:17 +0000 Gerrit-HasComments: Yes
