Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17830 )
Change subject: IMPALA-10902: In the case of outer join connections, skip unnecessary BE check ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/17830/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17830/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4251 PS5, Line 4251: BinaryPredicate.Operator op1 = ((BinaryPredicate) compoundPredicate.getChild(0)).getOp(); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17830/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: http://gerrit.cloudera.org:8080/#/c/17830/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@3520 PS5, Line 3520: sql = "select * from functional.nullrows where some_nulls = 'a' and some_nulls is null"; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17830/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@3529 PS5, Line 3529: sql = "select * from functional.nullrows where some_nulls = 'a' or some_nulls is null"; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17830/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@3589 PS5, Line 3589: sql = "select * from functional.nullrows where !(some_nulls IS NOT DISTINCT FROM NULL)"; line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17830 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f4db9b5aa00ee5117118696c58c07ffaaf0b66 Gerrit-Change-Number: 17830 Gerrit-PatchSet: 5 Gerrit-Owner: pengdou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Sat, 08 Oct 2022 10:27:44 +0000 Gerrit-HasComments: Yes
