Jian Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17830 )

Change subject: IMPALA-10902: In the case of outer join connections, skip 
unnecessary BE check
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17830/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/17830/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2815
PS6, Line 2815:       return evalIsTrueWithNullSlotAtFE(p);
It's more like moving the constant folding optimization to the native java 
implementations, the main benefit comes from reducing the overhead of JNI 
calls, am I correct?



--
To view, visit http://gerrit.cloudera.org:8080/17830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If6f4db9b5aa00ee5117118696c58c07ffaaf0b66
Gerrit-Change-Number: 17830
Gerrit-PatchSet: 6
Gerrit-Owner: pengdou <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jian Zhang <[email protected]>
Gerrit-Reviewer: Xianqing He <[email protected]>
Gerrit-Reviewer: pengdou <[email protected]>
Gerrit-Comment-Date: Sun, 09 Oct 2022 11:08:31 +0000
Gerrit-HasComments: Yes

Reply via email to