Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18705 )
Change subject: IMPALA-11417: Support outer join elimination optimization ...................................................................... Patch Set 8: (4 comments) Thanks for the changes! http://gerrit.cloudera.org:8080/#/c/18705/8/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/18705/8/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java@600 PS8, Line 600: false Can you rewrite this to use the single argument version? (same for AnalyticInfo.java) http://gerrit.cloudera.org:8080/#/c/18705/8/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test File testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test: http://gerrit.cloudera.org:8080/#/c/18705/8/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test@15 PS8, Line 15: 2.05M It is interesting, why did the cardinality change? http://gerrit.cloudera.org:8080/#/c/18705/8/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test@43 PS8, Line 43: not According to the plan the right side was actually eliminated. http://gerrit.cloudera.org:8080/#/c/18705/8/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test@59 PS8, Line 59: Left outer join an inline view Can you add another one with an inline view where the whole JOIN is included in the view? I think that this is an important use case of this optimization, as it seems more likely to use a view this way than to write a join where we don't use the right side at all. -- To view, visit http://gerrit.cloudera.org:8080/18705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2e68263a029ac84a4f35b0846b22aa42d7ceece Gerrit-Change-Number: 18705 Gerrit-PatchSet: 8 Gerrit-Owner: Jian Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Sat, 08 Oct 2022 14:24:37 +0000 Gerrit-HasComments: Yes
