Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18705 )
Change subject: IMPALA-11417: Support outer join elimination optimization ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18705/9/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/18705/9/common/thrift/Query.thrift@602 PS9, Line 602: 149: optional bool trust_pk_fk_constraints = true; I think that this should be false by default, otherwise this is a potential breaking change as FK/PK constraints are not enforced. Users who trust their constraints can turn it on by default using flag default_query_options. http://gerrit.cloudera.org:8080/#/c/18705/8/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/18705/8/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java@600 PS8, Line 600: > Can you rewrite this to use the single argument version? (same for Analytic Can you do this rewrite to reduce the footprint of the change? http://gerrit.cloudera.org:8080/#/c/18705/6/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test File testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test: http://gerrit.cloudera.org:8080/#/c/18705/6/testdata/workloads/functional-planner/queries/PlannerTest/outer-join-elimination.test@1 PS6, Line 1: # Test Case Summary: > Done. Some unoptimized cases can be optimized in the following changes, for Can you add some simple EE tests too? e.g. on of the planner tests in https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/outer-joins.test with both enabling and disabling the query option. Large results could be avoided by adding order by + limit or an aggregation on the result. -- To view, visit http://gerrit.cloudera.org:8080/18705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2e68263a029ac84a4f35b0846b22aa42d7ceece Gerrit-Change-Number: 18705 Gerrit-PatchSet: 9 Gerrit-Owner: Jian Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 14:06:19 +0000 Gerrit-HasComments: Yes
