Jian Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19029 )
Change subject: IMPALA-11606: add 'untracked memory' metric. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/19029/7/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/19029/7/be/src/runtime/mem-tracker.cc@56 PS7, Line 56: MemTracker* mem_tracker_; How about `const MemTracker* mem_tracker_` if `mem_tracker_` is not changed after UntrackedMemoryMetric created. -- To view, visit http://gerrit.cloudera.org:8080/19029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib16e00109d732f759c96c7a967eb1cc32124a03f Gerrit-Change-Number: 19029 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Wed, 12 Oct 2022 09:01:11 +0000 Gerrit-HasComments: Yes
