Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19148 )
Change subject: IMPALA-11666: Modify the warning message when table statistics may be corrupt ...................................................................... Patch Set 2: (5 comments) Looks good! http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java@332 PS2, Line 332: number of rows nit row count http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java@333 PS2, Line 333: ii) nit b) http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java@333 PS2, Line 333: i nit a) http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java@333 PS2, Line 333: corresponding nit remove http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java@335 PS2, Line 335: "The latter case does not necessarily imply the existence of corrupt \n" + : "statistics when the corresponding tables are transactional I wonder if it is possible to exclude transactional table names from the above list. In this way, we can report the warning message for tables with corrupted stats only. -- To view, visit http://gerrit.cloudera.org:8080/19148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I404b00db97f1fa0f6e67995c6e85a124ccf242ef Gerrit-Change-Number: 19148 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 18 Oct 2022 14:32:17 +0000 Gerrit-HasComments: Yes
