Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19148 )
Change subject: IMPALA-11666: Modify the warning message when table statistics may be corrupt ...................................................................... Patch Set 4: Code-Review+1 (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/19148/2/fe/src/main/java/org/apache/impala/planner/Planner.java@336 PS2, Line 336: transactional > > Probably iceberg-v2 tables can also hit this case? Yeah, it's possible to have 0 rows and non-zero data files in Iceberg V2 tables. Current Hive in minicluster does not support Iceberg tables. After https://gerrit.cloudera.org/#/c/19149/ is merged I think we'll be able to write such interop tests. Currently adding an Iceberg V2 table to the testdata requires a few extra steps, so I don't think it's necessary for this simple change. -- To view, visit http://gerrit.cloudera.org:8080/19148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I404b00db97f1fa0f6e67995c6e85a124ccf242ef Gerrit-Change-Number: 19148 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 21 Oct 2022 13:30:43 +0000 Gerrit-HasComments: Yes
