Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19157 )
Change subject: IMPALA-11674: Fix timeout detection for TSSLSocket ...................................................................... Patch Set 1: (2 comments) Compared TSocket::read() and TSocket::peek() between 0.9.3 and 0.16.0, did not see changes which could affect timeout. We only need to fix the issue caused by the changes in TSSLSocket::read() and TSSLSocket::peek(). The code change looks good to me. Only a few minor comments. http://gerrit.cloudera.org:8080/#/c/19157/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19157/1//COMMIT_MSG@53 PS1, Line 53: complete without error. Run same test without SSL and make sure it works as expected. http://gerrit.cloudera.org:8080/#/c/19157/1/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/19157/1/be/src/rpc/thrift-util.cc@256 PS1, Line 256: (e.getType() == TTransportException::TIMED_OUT && : strstr(e.what(), "EAGAIN (timed out)") != nullptr) || : (e.getType() == TTransportException::TIMED_OUT && : strstr(e.what(), "THRIFT_POLL (timed out)") != nullptr) Could we simplify as "(e.getType() == TTransportException::TIMED_OUT && strstr(e.what(), "(timed out)") != nullptr) -- To view, visit http://gerrit.cloudera.org:8080/19157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad168a1c96d751a3c50d924e6ecaf6404e589ab Gerrit-Change-Number: 19157 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 19 Oct 2022 22:50:00 +0000 Gerrit-HasComments: Yes
