Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19157 )
Change subject: IMPALA-11674: Fix timeout detection for TSSLSocket ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19157/3/tests/custom_cluster/test_thrift_socket.py File tests/custom_cluster/test_thrift_socket.py: http://gerrit.cloudera.org:8080/#/c/19157/3/tests/custom_cluster/test_thrift_socket.py@79 PS3, Line 79: expected_count=-1 > Suggest to set expected_count as -1, which means at least one match is expe Good idea. Done. http://gerrit.cloudera.org:8080/#/c/19157/3/tests/custom_cluster/test_thrift_socket.py@94 PS3, Line 94: expected_count=- > same comment as last one. Done -- To view, visit http://gerrit.cloudera.org:8080/19157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad168a1c96d751a3c50d924e6ecaf6404e589ab Gerrit-Change-Number: 19157 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Oct 2022 22:10:51 +0000 Gerrit-HasComments: Yes
