Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19055 )
Change subject: IMPALA-3119: DDL support for bucketed tables ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/19055/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19055/10//COMMIT_MSG@29 PS10, Line 29: the hash partition is equivalent to a bucket, > If add supported "CLUSTERED" in cup file, execute SQL with CLUTERED in hint I see. Previously, CLUSTERED is identified as an IDENTIFIER. Now we define it as a keyword. So we have to add a new production rule in plan_hint for KW_CLUSTERED, just like what we have done for KW_STRAIGHT_JOIN, i.e. plan_hint ::= KW_STRAIGHT_JOIN {: RESULT = new PlanHint("straight_join"); :} | KW_CLUSTERED {: RESULT = new PlanHint("clustered"); :} | IDENT:name {: RESULT = new PlanHint(name); :} ... http://gerrit.cloudera.org:8080/#/c/19055/10/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/19055/10/fe/src/main/cup/sql-parser.cup@1705 PS10, Line 1705: {: RESULT = new Pair<List<String>, TSortingOrder>(null, TSortingOrder.LEXICAL); :} > I Got. This hasn't been addressed. -- To view, visit http://gerrit.cloudera.org:8080/19055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I919b4d4139bc3a7784fa6fdb6f064e25666d548e Gerrit-Change-Number: 19055 Gerrit-PatchSet: 11 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 27 Oct 2022 05:08:01 +0000 Gerrit-HasComments: Yes
