Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19055 )
Change subject: IMPALA-3119: DDL support for bucketed tables ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/19055/10/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/19055/10/fe/src/main/cup/sql-parser.cup@1636 PS10, Line 1636: :} > Yes, i think so. But it was originally intended that later versions would a We already support the SortBy clause. Currently it's independent with the ClusteredBy clause, e.g. CREATE TABLE tbl (i int, s string) CLUSTERED BY (i) INTO 24 BUCKETS SORT BY (i); What I mean is changing it to CREATE TABLE tbl (i int, s string) CLUSTERED BY (i) SORT BY (i) INTO 24 BUCKETS; The latter one is the syntax used in Hive and SparkSQL. I think we don't need to add any new feature for this, and the grammer might be easier that we can add the EMPTY production rule. -- To view, visit http://gerrit.cloudera.org:8080/19055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I919b4d4139bc3a7784fa6fdb6f064e25666d548e Gerrit-Change-Number: 19055 Gerrit-PatchSet: 13 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 27 Oct 2022 12:31:24 +0000 Gerrit-HasComments: Yes
