Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 )
Change subject: IMPALA-11669: (addendum) Set TConfiguration in DeserializeThriftMsg ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/rpc/thrift-util.h File be/src/rpc/thrift-util.h: http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/rpc/thrift-util.h@42 PS2, Line 42: int ThriftRpcMaxMessageSize() define as inline function http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/rpc/thrift-util.h@44 PS2, Line 44: inline int ThriftDefaultMaxMessageSize() { add a comment for this function http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/transport/TSaslTransport.cpp File be/src/transport/TSaslTransport.cpp: http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/transport/TSaslTransport.cpp@43 PS2, Line 43: TMemoryBuffer(DEFAULT_MEM_BUF_SIZE should we set DefaultTConfiguration() for this TMemoryBuffer? http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/transport/TSaslTransport.cpp@53 PS2, Line 53: TMemoryBuffer() same comment as last one. http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: http://gerrit.cloudera.org:8080/#/c/19179/2/be/src/util/parquet-reader.cc@75 PS2, Line 75: TMemoryBuffer Should we set TConfiguration? -- To view, visit http://gerrit.cloudera.org:8080/19179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Gerrit-Change-Number: 19179 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 31 Oct 2022 06:02:03 +0000 Gerrit-HasComments: Yes
