Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 )
Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/19179/6/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: http://gerrit.cloudera.org:8080/#/c/19179/6/be/src/util/parquet-reader.cc@78 PS6, Line 78: DefaultTConfiguration()) I looked through the Clang-Tidy output, and I see this: /home/ubuntu/Impala/be/src/util/parquet-reader.cc:78:7: error: use of undeclared identifier 'DefaultTConfiguration'; did you mean 'impala::DefaultTConfiguration'? DefaultTConfiguration())); ^~~~~~~~~~~~~~~~~~~~~ impala::DefaultTConfiguration /home/ubuntu/Impala/be/src/rpc/thrift-util.h:55:49: note: 'impala::DefaultTConfiguration' declared here std::shared_ptr<apache::thrift::TConfiguration> DefaultTConfiguration(); Since we are not in the impala namespace, the compiler wants impala::DefaultTConfiguration(). -- To view, visit http://gerrit.cloudera.org:8080/19179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Gerrit-Change-Number: 19179 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 31 Oct 2022 18:08:43 +0000 Gerrit-HasComments: Yes
