Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/19181/1/be/src/runtime/fragment-state.cc File be/src/runtime/fragment-state.cc: http://gerrit.cloudera.org:8080/#/c/19181/1/be/src/runtime/fragment-state.cc@108 PS1, Line 108: return apache::thrift::ThriftDebugString(fragment_); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/19181/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/19181/1/common/thrift/ImpalaService.thrift@746 PS1, Line 746: // Specify whether to use the debug mode for codegen cache. In debug mode, we will insert line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19181/1/common/thrift/ImpalaService.thrift@747 PS1, Line 747: // a full key for the cache and allow more statistics, otherwise, a hashcode will be used line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19181/1/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/19181/1/tests/common/test_result_verifier.py@759 PS1, Line 759: def assert_codegen_cache_hit(profile_string, expect_hit): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19181/1/tests/custom_cluster/test_codegen_cache.py File tests/custom_cluster/test_codegen_cache.py: http://gerrit.cloudera.org:8080/#/c/19181/1/tests/custom_cluster/test_codegen_cache.py@24 PS1, Line 24: @SkipIf.not_hdfs flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 31 Oct 2022 15:48:59 +0000 Gerrit-HasComments: Yes
