Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19181/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/19181/2/be/src/codegen/llvm-codegen.cc@1954 PS2, Line 1954: out << "Fragment Plan: " << apache::thrift::ThriftDebugString(state_->fragment()) > Please make sure you don't output sensitive data with ThriftDebugString(). The ThriftDebugString should be fine here, a similar output in previous code can be found: https://github.com/apache/impala/blob/bd88b71edd305dd448e9ec33a0cfd10f97177c4e/be/src/exec/exec-node.cc#L111. Also, it would fail the build compilation if the fragment contains HasSecret struct: https://github.com/apache/impala/blob/bd88b71edd305dd448e9ec33a0cfd10f97177c4e/be/src/util/thrift-debug-util.h#L122 -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 31 Oct 2022 22:56:04 +0000 Gerrit-HasComments: Yes
