Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 )
Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer ...................................................................... Patch Set 12: > I ran thrift-server-test in a loop, and it hits the assert within a > few dozen runs. It seems like there might be a race condition > around the thrift_max_message_size parameter, but I don't > understand why it would race. I wonder if somehow the flagsetter interacts: https://github.com/apache/impala/blob/master/be/src/rpc/thrift-server-test.cc#L152 -- To view, visit http://gerrit.cloudera.org:8080/19179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Gerrit-Change-Number: 19179 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 01 Nov 2022 21:31:30 +0000 Gerrit-HasComments: No
