Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 )
Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer ...................................................................... Patch Set 12: > > Patch Set 12: > > > > > Patch Set 12: > > > > > > I wonder if somehow the flagsetter interacts: > > > https://github.com/apache/impala/blob/master/be/src/rpc/thrift-server-test.cc#L152 > > > > Agree, that looks like the culprit. I thought the > ScopedFlagSetter suppose to restore the flag after it goes out of > scope? > > Tried couple stuff to limit FLAGS_thrift_rpc_max_message_size > change only for relevant tests, but no luck so far. > The other way that works for me is to enforce low > FLAGS_thrift_rpc_max_message_size > for all test within thrift-server-test. All tests still pass even > with low FLAGS_thrift_rpc_max_message_size. Yeah, and I think one option is to split off the tests that modify thrift_rpc_max_message_size into their own backend test. When I run the set of tests that don't touch thrift_rpc_max_message_size on their own, they pass. When I run the set of tests that use the lower thrift_rpc_max_message_size on their own, they pass. I'm ok with using the lower message size for this test if everything works appropriately. -- To view, visit http://gerrit.cloudera.org:8080/19179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Gerrit-Change-Number: 19179 Gerrit-PatchSet: 12 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 01 Nov 2022 23:37:16 +0000 Gerrit-HasComments: No
