Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19179 )
Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer ...................................................................... IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer This patch adds DefaultTConfiguration into TMemoryBuffer used within DeserializeThriftMsg, ThriftSerializer, and TSaslTransport. This patch also makes some adjustment, including: - Refactor AssignDefaultTConfiguration to SetMaxMessageSize. - Supply DefaultTConfiguration into the constructor of THttpTransport and TSaslTransport. - Supply DefaultTConfiguration through the constructor of TBufferedTransport. Testing: - Add DCHECK_EQ in places where we expect that it should pick up DefaultTConfiguration. - Add SerDeBuffer100MB test. - Lower thrift_rpc_max_message_size to 128KB for all tests in thrift-server-test to avoid race condition. - Pass core tests. - Manually run and pass test scenario described in testdata/scale_test_metadata/ both in SSL and no SSL setup. Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Reviewed-on: http://gerrit.cloudera.org:8080/19179 Reviewed-by: Wenzhe Zhou <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/rpc/TAcceptQueueServer.cpp M be/src/rpc/authentication.cc M be/src/rpc/thrift-client.cc M be/src/rpc/thrift-server-test.cc M be/src/rpc/thrift-server.h M be/src/rpc/thrift-util-test.cc M be/src/rpc/thrift-util.cc M be/src/rpc/thrift-util.h M be/src/transport/THttpTransport.cpp M be/src/transport/TSaslServerTransport.cpp M be/src/transport/TSaslTransport.cpp M be/src/util/parquet-reader.cc M testdata/scale_test_metadata/README.md 13 files changed, 127 insertions(+), 41 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, but someone else must approve Joe McDonnell: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/19179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I37a8e71c64a09ec8aeccb96c6ee59ca82c0b37cb Gerrit-Change-Number: 19179 Gerrit-PatchSet: 14 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
