Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19195 )
Change subject: IMPALA-11699: Fix NPE in FE tests thrown from static code of FileSystemUtil ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19195/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19195/3/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@870 PS3, Line 870: BackendConfig.create(new TBackendGflags()); > Is there a property set only in tests we could assert on to ensure this is Good point! I think RuntimeEnv.INSTANCE.isTestEnv() is the most relevant one. But it's still not set in all tests (tracked in IMPALA-9780). What about adding the assertion in IMPALA-9780? -- To view, visit http://gerrit.cloudera.org:8080/19195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c056791406cd4535a7e43889dbb73d153b06f0a Gerrit-Change-Number: 19195 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 04 Nov 2022 22:31:20 +0000 Gerrit-HasComments: Yes
