Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19195 )
Change subject: IMPALA-11699: Fix NPE in FE tests thrown from static code of FileSystemUtil ...................................................................... IMPALA-11699: Fix NPE in FE tests thrown from static code of FileSystemUtil FileSystemUtil has static code to get configuration from BackendConfig.INSTANCE which could be null in some FE tests. In commit c1610a163 of IMPALA-11469, we fixed the issue by modifying the failed FE tests to extend FrontendTestBase which can make sure BackendConfig.INSTANCE is initialized. However, AcidUtilsTest and TestCaseLoaderTest also have the issue. But they are missed since the issue depends on the test order. If a test that inits BackendConfig.INSTANCE runs first, the following tests won't suffer this issue. To avoid new tests hitting this issue again, this patch inits BackendConfig.INSTANCE lazily in the static code of FileSystemUtil. Also adds a warning mentioning this should only happen in tests. Note that in impalad and catalogd, BackendConfig.INSTANCE is initialized in constructors of JniFrontend and JniCatalog. The changes of c1610a163 is redundant after this patch so they are reverted. Tests: - Run FE tests one by one so each test won't depend on any previous env. Only found AcidUtilsTest and TestCaseLoaderTest have the issue. Verified this patch fixes the issue in these two tests. Change-Id: I5c056791406cd4535a7e43889dbb73d153b06f0a Reviewed-on: http://gerrit.cloudera.org:8080/19195 Reviewed-by: Daniel Becker <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java 3 files changed, 8 insertions(+), 4 deletions(-) Approvals: Daniel Becker: Looks good to me, but someone else must approve Impala Public Jenkins: Verified Michael Smith: Looks good to me, but someone else must approve Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5c056791406cd4535a7e43889dbb73d153b06f0a Gerrit-Change-Number: 19195 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
