Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19220 )
Change subject: IMPALA-11707: Fix global runtime IN-list filter of numeric types are AlwaysFalse ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter-ir.cc File be/src/util/in-list-filter-ir.cc: http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter-ir.cc@84 PS1, Line 84: } \ Shouldn't we also insert a DHCECK here, line on L43? http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter.h File be/src/util/in-list-filter.h: http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter.h@149 PS1, Line 149: auto Why are we changing the return type? If we change it, it is inconsistent with inline bool insert(StringValue v). Also, typing out the actual type would be more informative, although possibly a bit long. -- To view, visit http://gerrit.cloudera.org:8080/19220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie90b2bce5e5ec6f6906ce9d2090b0ab19d48cc78 Gerrit-Change-Number: 19220 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 07 Nov 2022 16:02:50 +0000 Gerrit-HasComments: Yes
