Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19220 )
Change subject: IMPALA-11707: Fix global runtime IN-list filter of numeric types are AlwaysFalse ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter-ir.cc File be/src/util/in-list-filter-ir.cc: http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter-ir.cc@84 PS1, Line 84: DCHECK_EQ(total_entries_, values_.size() + newly_inserted_values_.size()); \ > Shouldn't we also insert a DHCECK here, line on L43? Yeah, nice catch! http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter.h File be/src/util/in-list-filter.h: http://gerrit.cloudera.org:8080/#/c/19220/1/be/src/util/in-list-filter.h@149 PS1, Line 149: pair > Why are we changing the return type? The motivation is providing the same insert interfaces as boost::unordered_set's so the IN_LIST_FILTER_INSERT_BATCH macro can be used by both numeric and string type filters. Yeah, it makes sense to change the above insert() method to be consistent. Changed "auto" to std::pair<boost::unordered_set<StringValue>::iterator, bool> http://gerrit.cloudera.org:8080/#/c/19220/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test File testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test: http://gerrit.cloudera.org:8080/#/c/19220/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test@217 PS1, Line 217: 7 This is actually 7. I forgot to update the result after I changed the condition from "b.id_col < 4" to "b.id_col < 5".. -- To view, visit http://gerrit.cloudera.org:8080/19220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie90b2bce5e5ec6f6906ce9d2090b0ab19d48cc78 Gerrit-Change-Number: 19220 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 01:40:53 +0000 Gerrit-HasComments: Yes
