Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19190 )
Change subject: IMPALA-11692: Struct slot memory sharing involving select * not working properly ...................................................................... Patch Set 4: Code-Review+1 (2 comments) The logic looks good to me, only some comments about naming/comments. http://gerrit.cloudera.org:8080/#/c/19190/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/19190/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@287 PS4, Line 287: private class ExpandedPathInfo { This is only about expanded star expressions, right? It would be nice to include "star" in the name or at least note this in a comment. http://gerrit.cloudera.org:8080/#/c/19190/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@307 PS4, Line 307: : private final Path expandedPath_; : private final Path originalRootPath_; Can you add a small comment for these, e.g. path of expanded item, path of original star expression? -- To view, visit http://gerrit.cloudera.org:8080/19190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I346c2808c1aa5e77e3cdf3593f7f48ac96516c00 Gerrit-Change-Number: 19190 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 13:07:42 +0000 Gerrit-HasComments: Yes
