Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19190 )
Change subject: IMPALA-11692: Struct slot memory sharing involving select * not working properly ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/19190/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/19190/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@287 PS4, Line 287: private class StarExpandedPathIn > This is only about expanded star expressions, right? It would be nice to in Yes, it is only about star paths, changed the name to ExpandedPathInfo. Also renamed the parameters of addStarExpandedPath() to be more informative. http://gerrit.cloudera.org:8080/#/c/19190/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@297 PS4, Line 297: // types will have the complex type so it's not empty. > There are some TODOs here, I think we should address them in a separate cha Created a JIRA issue and referenced it here. http://gerrit.cloudera.org:8080/#/c/19190/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@307 PS4, Line 307: } : : // The path expanded from a star sele > Can you add a small comment for these, e.g. path of expanded item, path of Done -- To view, visit http://gerrit.cloudera.org:8080/19190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I346c2808c1aa5e77e3cdf3593f7f48ac96516c00 Gerrit-Change-Number: 19190 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 08 Nov 2022 15:51:55 +0000 Gerrit-HasComments: Yes
