Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19181/3/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/19181/3/be/src/runtime/exec-env.cc@104 PS3, Line 104: "Specify the capacity of the codegen cache. If set to 0, codegen cache is disabled."); > It is parsed by ParseMemSpec() which is used for parsing the size everywher Done http://gerrit.cloudera.org:8080/#/c/19181/3/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/19181/3/be/src/runtime/query-state.h@468 PS3, Line 468: bool disable_codegen_cache_ = false; > I think it follows the norm of disable_codegen in the query option, even th Done -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 10 Nov 2022 00:57:14 +0000 Gerrit-HasComments: Yes
