Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/19181/7/be/src/codegen/llvm-codegen-cache.cc File be/src/codegen/llvm-codegen-cache.cc: http://gerrit.cloudera.org:8080/#/c/19181/7/be/src/codegen/llvm-codegen-cache.cc@160 PS7, Line 160: codegen->num_instructions_->value(), codegen->function_names_hashcode_, mem_charge); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19181/7/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/19181/7/be/src/codegen/llvm-codegen.cc@1135 PS7, Line 1135: // The names hashcode should be the same unless there is a collision on the key, we expect line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/19181/7/be/src/codegen/llvm-codegen.cc@1138 PS7, Line 1138: LOG(WARNING) << "The codegen cache entry contains a different function names hashcode: " line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/19181/7/be/src/codegen/llvm-codegen.cc@1993 PS7, Line 1993: out << "Fragment Plan: " << apache::thrift::ThriftDebugString(state_->fragment()) Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 16:04:05 +0000 Gerrit-HasComments: Yes
