Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19233 )
Change subject: IMPALA-11720: Deflake FileMetadataLoaderTest due to FileSystem closed ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@871 PS1, Line 871: static { > Oops! Nice catch! Oh, somehow I managed to suggest the wrong version too. New version - '_tmp.' - looks right from https://github.com/apache/impala/blob/master/be/src/util/backend-gflag-util.cc#L194. http://gerrit.cloudera.org:8080/#/c/19233/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@873 PS1, Line 873: // getIgnoredDirPrefixList() could return null if BackendConfig is created with > I realized that external FE could also run into this (IMPALA-10515). Added I was thinking of the comma-separated list of defaults at https://github.com/apache/impala/blob/master/be/src/util/backend-gflag-util.cc#L194. But since that's in C++ code, it'd be hard to share the same source. -- To view, visit http://gerrit.cloudera.org:8080/19233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f96950210c9a0124fe03696ef334cb00b057ab Gerrit-Change-Number: 19233 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 14 Nov 2022 17:41:04 +0000 Gerrit-HasComments: Yes
