Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19233 )
Change subject: IMPALA-11720: Deflake FileMetadataLoaderTest due to FileSystem closed ...................................................................... Patch Set 3: (5 comments) Thanks for your feedbacks! http://gerrit.cloudera.org:8080/#/c/19233/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19233/2//COMMIT_MSG@13 PS2, Line 13: in File > nit. remove. Done http://gerrit.cloudera.org:8080/#/c/19233/2//COMMIT_MSG@24 PS2, Line 24: created > nit. created? Oops, done http://gerrit.cloudera.org:8080/#/c/19233/2//COMMIT_MSG@30 PS2, Line 30: C > nit C++ Done http://gerrit.cloudera.org:8080/#/c/19233/2//COMMIT_MSG@33 PS2, Line 33: to maintain the state of BackendConfig.INSTANCE : in the static code of FileSys > nit. to maintain the state of BackendConfig.INSTANCE in the static code of Done http://gerrit.cloudera.org:8080/#/c/19233/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/19233/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@880 PS2, Line 880: BackendConfig > nit. use of BackendConfig.INSTANCE will make the message clear. Done -- To view, visit http://gerrit.cloudera.org:8080/19233 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f96950210c9a0124fe03696ef334cb00b057ab Gerrit-Change-Number: 19233 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 14 Nov 2022 01:06:01 +0000 Gerrit-HasComments: Yes
