Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 8: (2 comments) Reconstruct the CodeGenCache constructor to have counters initialized. Adds a hash code for function names in the LlvmCodeGen, will examine it to make sure the cache entry should contain the functions we are looking for. http://gerrit.cloudera.org:8080/#/c/19181/5/be/src/codegen/llvm-codegen-cache.cc File be/src/codegen/llvm-codegen-cache.cc: http://gerrit.cloudera.org:8080/#/c/19181/5/be/src/codegen/llvm-codegen-cache.cc@76 PS5, Line 76: } > nit: we could do all the rest of this method in the constructor, and probab Done http://gerrit.cloudera.org:8080/#/c/19181/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/19181/5/be/src/codegen/llvm-codegen.cc@1137 PS5, Line 1137: if (function_names_hashcode_ != entry.function_names_hashcode) { : LOG(WARNING) > Could we fall back to regular codegen path if we encounter this? Adds a logic in patch 7 to examine the hash code of function names, if the cache doesn't match the hash code of current LlmvCodeGen, meaning the functions in the cache could be different, will fall back to regular path. -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 17 Nov 2022 16:25:33 +0000 Gerrit-HasComments: Yes
