Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19220 )
Change subject: IMPALA-11707: Fix global runtime IN-list filter of numeric types are AlwaysFalse ...................................................................... Patch Set 4: (1 comment) > Patch Set 3: Verified-1 > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8816/ Fixed a bug causing this failure. http://gerrit.cloudera.org:8080/#/c/19220/3/be/src/util/in-list-filter.cc File be/src/util/in-list-filter.cc: http://gerrit.cloudera.org:8080/#/c/19220/3/be/src/util/in-list-filter.cc@153 PS3, Line 153: SET_VAR This is wrong for string types InListFilter because values should be inserted into newly_inserted_values_ first. MaterializeValues() will then allocate mem and copy them to values_. If we insert them to values_ directly, MaterializeValues() will skip mem allocation so the string pointers will be invalid after the protobuf objects are destroyed. -- To view, visit http://gerrit.cloudera.org:8080/19220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie90b2bce5e5ec6f6906ce9d2090b0ab19d48cc78 Gerrit-Change-Number: 19220 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 21 Nov 2022 12:36:11 +0000 Gerrit-HasComments: Yes
