Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19220 )
Change subject: IMPALA-11707: Fix global runtime IN-list filter of numeric types are AlwaysFalse ...................................................................... Patch Set 3: Code-Review+2 (2 comments) +2 to carry Daniel's +1. http://gerrit.cloudera.org:8080/#/c/19220/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19220/2//COMMIT_MSG@21 PS2, Line 21: Tests > Just the test section of the commit message Done http://gerrit.cloudera.org:8080/#/c/19220/2/be/src/util/in-list-filter.h File be/src/util/in-list-filter.h: http://gerrit.cloudera.org:8080/#/c/19220/2/be/src/util/in-list-filter.h@164 PS2, Line 164: nd(S > We need to use the same method name as it's used in IN_LIST_FILTER_INSERT_B Done -- To view, visit http://gerrit.cloudera.org:8080/19220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie90b2bce5e5ec6f6906ce9d2090b0ab19d48cc78 Gerrit-Change-Number: 19220 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 18 Nov 2022 19:49:05 +0000 Gerrit-HasComments: Yes
