Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19270 )
Change subject: IMPALA-11739: Iceberg partitioning column cannot be filtered not equal NULL or equal NULL ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/19270/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19270/1//COMMIT_MSG@9 PS1, Line 9: s > nit: each line should be limited to 72 characters or less if possible. Thanks for your advice. http://gerrit.cloudera.org:8080/#/c/19270/1//COMMIT_MSG@10 PS1, Line 10: t > ditto Done http://gerrit.cloudera.org:8080/#/c/19270/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19270/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@659 PS1, Line 659: return null; > If just 'return null', 'col eq val' or 'col neq val' will not be pushed dow I change it just like https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java#L590 -- To view, visit http://gerrit.cloudera.org:8080/19270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c50978ebac2590622027a239db03f56b082de3 Gerrit-Change-Number: 19270 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Wed, 23 Nov 2022 09:05:09 +0000 Gerrit-HasComments: Yes
