Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19270 )
Change subject: IMPALA-11739: Skip pushing down BinaryPredicate with NullLiteral for Iceberg tables ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/19270/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/19270/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@559 PS3, Line 559: BinaryPredicate with n > nit: BinaryPredicate Done http://gerrit.cloudera.org:8080/#/c/19270/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test: http://gerrit.cloudera.org:8080/#/c/19270/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test@317 PS3, Line 317: action = NULL > nit: Perhaps we should add '! =' test case Done -- To view, visit http://gerrit.cloudera.org:8080/19270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c50978ebac2590622027a239db03f56b082de3 Gerrit-Change-Number: 19270 Gerrit-PatchSet: 5 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 23 Nov 2022 10:20:56 +0000 Gerrit-HasComments: Yes
