Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 )
Change subject: IMPALA-11478: Cleanup JniCatalog ...................................................................... Patch Set 4: (2 comments) The refactor is pretty good! I just have minor comments. http://gerrit.cloudera.org:8080/#/c/19198/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19198/3//COMMIT_MSG@13 PS3, Line 13: Frontend test added as JniCatalogOpTest. > I checked manually the exceptions and the thread dump for getDbs and getCat Thanks for doing the experiment! These looks good to me. Just one question: "Time spent" in the last two logs don't have the actual duration. Is it missed by copy-paste mistake, or is it a bug? http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/common/JniUtil.java@176 PS4, Line 176: System.currentTimeMillis() - startTime nit: getDurationFromStart() -- To view, visit http://gerrit.cloudera.org:8080/19198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1932172e2d13a7aab2336661c18befb4407ec9ab Gerrit-Change-Number: 19198 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 01 Dec 2022 02:12:32 +0000 Gerrit-HasComments: Yes
