Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 )
Change subject: IMPALA-11478: Cleanup JniCatalog ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java@20 PS4, Line 20: import com.google.common.annotations.VisibleForTesting; > Using a static function from other class without prefixing with the class n Done http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java@252 PS4, Line 252: params.getNative_catalog_server_ptr(), params.getFrom_version()); : return new TGetCatalogDeltaResponse(catalog > This looks like a very common pattern, an alternative of execOp could avoid A specialized method called serialize added for this purpose http://gerrit.cloudera.org:8080/#/c/19198/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java@265 PS4, Line 265: return serialize( > If already cleaning up this could get a trailing _ (it confused me for a bi Done -- To view, visit http://gerrit.cloudera.org:8080/19198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1932172e2d13a7aab2336661c18befb4407ec9ab Gerrit-Change-Number: 19198 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 07 Dec 2022 10:31:08 +0000 Gerrit-HasComments: Yes
