Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py File bin/inline_pom.py: http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@22 PS4, Line 22: # Usage: inline_pom.py pom.xml > Nit: Commit message says usage is "inline_pom.py fe/pom.xml java/**/pom.xml Well, the commit message shows how to find all the relevant pom files, but this I was leaving more generic. http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@38 PS4, Line 38: print("export {}={}".format(name, value)) > This is just diagnostics? Yes. I might remove the export; I was experimenting with adding it to my laptop environment but it didn't help. http://gerrit.cloudera.org:8080/#/c/19314/4/bin/inline_pom.py@58 PS4, Line 58: print("Usage: inline_pom.py <pom.xml>...") > Nit: Make usage notes consistent Ack -- To view, visit http://gerrit.cloudera.org:8080/19314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4 Gerrit-Change-Number: 19314 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:16:29 +0000 Gerrit-HasComments: Yes
