Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 )
Change subject: [tools] Add inline_pom.py script for development ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19314/5/bin/inline_pom.py File bin/inline_pom.py: http://gerrit.cloudera.org:8080/#/c/19314/5/bin/inline_pom.py@61 PS5, Line 61: print("Replacing environment variables in {}".format(', '.join(sys.argv[1:]))) nit: maybe it is useful to print "WARNING" and tell user to be careful to not commit inlined pom. -- To view, visit http://gerrit.cloudera.org:8080/19314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I166574a8f1b27e938b96bd8119c030c761f0e8d4 Gerrit-Change-Number: 19314 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Dec 2022 18:20:48 +0000 Gerrit-HasComments: Yes
