Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 16: Code-Review+1 (3 comments) Thanks a lot! http://gerrit.cloudera.org:8080/#/c/19181/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19181/14//COMMIT_MSG@61 PS14, Line 61: e stored to the cac > I think it is a good idea, and changed the optimal mode to use hash code pl Nice! http://gerrit.cloudera.org:8080/#/c/19181/14//COMMIT_MSG@113 PS14, Line 113: From the result, it shows > I think the case mentioning here is to compare codegen disabled vs codegen Make sense. Yeah maybe in the future we can amortize the cost of LLVM codegen over queries or make the cache content persistent. http://gerrit.cloudera.org:8080/#/c/19181/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19181/16//COMMIT_MSG@139 PS16, Line 139: 1382.6 Yeah, the cache key size in NORMAL case is relatively large. Maybe we could optimize it a bit in next around of work. This also calls for a policy to eject less useful entries if not done yet. -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 16 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 14:46:08 +0000 Gerrit-HasComments: Yes
