Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 )
Change subject: IMPALA-11470: Add Cache For Codegen Functions ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/19181/16/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/19181/16/be/src/codegen/llvm-codegen.cc@2009 PS16, Line 2009: out << "Fragment Plan: " << apache::thrift::ThriftDebugString(state_->fragment()) > Can you replace this with the suggested function? While there is nothing to Tried, but RedactedDebugString doesn't support to print fragment. However, if the fragment contains a HasSecret struct, the build compilation should fail and I did try: https://github.com/apache/impala/blob/bd88b71edd305dd448e9ec33a0cfd10f97177c4e/be/src/util/thrift-debug-util.h#L122. The warning here seems false positive, always existing if using ThriftDebugString. -- To view, visit http://gerrit.cloudera.org:8080/19181 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If42c78a7f51fd582e5fe331fead494dadf544eb1 Gerrit-Change-Number: 19181 Gerrit-PatchSet: 16 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 05 Dec 2022 16:59:06 +0000 Gerrit-HasComments: Yes
