Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 )
Change subject: IMPALA-11478: Cleanup JniCatalog ...................................................................... Patch Set 7: Code-Review+1 (3 comments) I have some more comments on the 'shortDesc' strings. It'd be nice to add the operation targets so whenever we take a jstack we know the tables that each JniCatalog thread is working on. http://gerrit.cloudera.org:8080/#/c/19198/7/fe/src/main/java/org/apache/impala/common/JniUtil.java File fe/src/main/java/org/apache/impala/common/JniUtil.java: http://gerrit.cloudera.org:8080/#/c/19198/7/fe/src/main/java/org/apache/impala/common/JniUtil.java@146 PS7, Line 146: /** : * Warn if the result size or the response time exceeds thresholds. : */ nit: could you move these comment to line 174? http://gerrit.cloudera.org:8080/#/c/19198/7/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/19198/7/fe/src/main/java/org/apache/impala/service/JniCatalog.java@410 PS7, Line 410: priorize typo: prioritize Can we also add the table list in 'shortDesc'? i.e. String shortDesc = "prioritize load " + request.getObject_descs().stream() .map(TCatalogObject::getTable) .map(t -> t.getDb_name() + "." + t.getTbl_name()) .collect(Collectors.joining(", ")); http://gerrit.cloudera.org:8080/#/c/19198/7/fe/src/main/java/org/apache/impala/service/JniCatalog.java@478 PS7, Line 478: String shortDesc = "update table usage"; It'd be nice to add the table list here as well, i.e. String shortDesc = "update table usage " + thriftReq.getUsages().stream() .map(TTableUsage::getTable_name) .map(TableName::thriftToString) .collect(Collectors.joining(", ")); -- To view, visit http://gerrit.cloudera.org:8080/19198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1932172e2d13a7aab2336661c18befb4407ec9ab Gerrit-Change-Number: 19198 Gerrit-PatchSet: 7 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 12 Dec 2022 03:33:21 +0000 Gerrit-HasComments: Yes
