wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18829 )
Change subject: IMPALA-7942 (part 1): Add query hints for table cardinalities ...................................................................... Patch Set 9: > (1 comment) Hi Qifan, sorry for taking so long to reply. I consider about the different row hint for same table, I think this quite complicated. We get row hint of each table in TableRef.analyze(). If table ref A without #row hint, and table ref B with #row hint, and they are same physical table in fact. This means, we need to update TableRef_A, after we get row hint from TableRef_B. In this way, after we analyzed all tables, we need to check each table row hints again. This feature been going on for a long, so I recommand that we ignore the different row hint for same table, and keeping basic function of table row hint. And consider this in another patch. How do you think? -- To view, visit http://gerrit.cloudera.org:8080/18829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f0c773f4e67782a1428db64062f68afbd257af7 Gerrit-Change-Number: 18829 Gerrit-PatchSet: 9 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 13:17:32 +0000 Gerrit-HasComments: No
