wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18829 )
Change subject: IMPALA-7942 (part 1): Add query hints for table cardinalities ...................................................................... Patch Set 11: > > Patch Set 10: > > > > > Hi Quanlong, I submited pre-review-test, but failed in these > tests: > > > > > > authorization.test_ranger.TestRanger.test_show_grant_hive_privilege > > > generate_junitxml.buildall.run-custom-cluster-tests > > > > > > Seems unrelated to this patch. > > > > Here is the task url: > > https://jenkins.impala.io/job/pre-review-test/1490/console > > Thanks Sheng! > > test_show_grant_hive_privilege is broken by IMPALA-10986 since the > number of added Ranger policies in tests reaches a certain number > after IMPALA-10986 in the pre-review-test. I think all (or most of) > the authorization-related tests are run with a single instance of > the Ranger server in the pre-review-test. > > We do not observe it in the gerrit-verify-dryrun-external probably > because those authorization-related tests are run in different > shards each having its own instance of Ranger server and the limit > is not reached yet. So the failure was not caused by your patch. I > have a patch at https://gerrit.cloudera.org/c/19373 that will be > approved soon. Ok thanks for replay. I've already rebase this patch. Anyone could help to start a gerrit-verify-dryrun task to verify this patch? -- To view, visit http://gerrit.cloudera.org:8080/18829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f0c773f4e67782a1428db64062f68afbd257af7 Gerrit-Change-Number: 18829 Gerrit-PatchSet: 11 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 03 Jan 2023 06:46:11 +0000 Gerrit-HasComments: No
