Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19387 )
Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and test_mixed_file_format ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/19387/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19387/2//COMMIT_MSG@9 PS2, Line 9: Iceberg hardcodes URIs in metadata files. If the table was written > https://github.com/apache/impala/blob/master/testdata/bin/rewrite-iceberg-m This patch is ok if we want to take longer to dig into this. However I think the main problem is that new tests are in /test-warehouse/functional_parquet.db rather than /test-warehouse/iceberg_test, so https://github.com/apache/impala/blob/4.2.0/testdata/bin/load-test-warehouse-snapshot.sh#L119 is insufficient. The only directories I see named metadata look to be iceberg tables, so I think removing /iceberg_test from that 'find' command would fix these tests. -- To view, visit http://gerrit.cloudera.org:8080/19387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f126de80c6e7f825d02f6814fcf69ae320a781 Gerrit-Change-Number: 19387 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 21 Dec 2022 17:43:27 +0000 Gerrit-HasComments: Yes
