Noemi Pap-Takacs has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19387 )

Change subject: IMPALA-11807: Fix TestIcebergTable.test_avro_file_format and 
test_mixed_file_format
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19387/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19387/2//COMMIT_MSG@9
PS2, Line 9: Iceberg hardcodes URIs in metadata files. If the table was written
> The other thing we could try I think is creating a hadoop catalog
 > table:
 >
 > 'iceberg.catalog'='hadoop.catalog',
 > 'iceberg.catalog_location'='/test-warehouse/iceberg_test/hadoop_catalog'

These table properties are interpreted only by Impala. When we create a table 
using Hive, we can give these properties, but Hive will still create the table 
to Hive Catalog and not to the location specified in the properties.
I tried this proposed solution: the table was created and is shown in the 
database, but I got a TableLoadingException saying that the table does not 
exist because the location does not match with the properties. If I add the 
same location as in the example above, I still get the TableLoadingException, 
if the properties are present. Even though the files will be created at the 
given location.

I suggest skipping these tests for now, and let us investigate this issue 
further in the future.
I added only the LOCATION property for now, and specified it to be the same as 
the 'iceberg.catalog_location' in the example above. Hopefully it will result 
in usable snapshots.



--
To view, visit http://gerrit.cloudera.org:8080/19387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2f126de80c6e7f825d02f6814fcf69ae320a781
Gerrit-Change-Number: 19387
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
Gerrit-Comment-Date: Thu, 22 Dec 2022 13:28:12 +0000
Gerrit-HasComments: Yes

Reply via email to